Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with scripts appearing next to single product buttons #2923

Merged
merged 5 commits into from
Jun 29, 2021

Conversation

cristian-ungureanu
Copy link
Contributor

Summary

  • The issue here was that we targeted all elements in that div with > *. If a plugin come and add a script there, the script tag would have display: flex;
  • Fixed an issue for grouped products. The padding of the primary button was applying to inputs for grouped products.

NOTE: You need to have https://github.com/Codeinwp/neve-pro-addon/pull/1431

Will affect visual aspect of the product

NO

Screenshots

https://prnt.sc/15otb1h

Test instructions

Closes #2903, Closes #2901, Closes #2915, Closes codeinwp/neve-pro-addon#1414

@github-actions
Copy link

github-actions bot commented Jun 23, 2021

Plugin build for c1c67de is ready 🛎️!

@selul
Copy link
Contributor

selul commented Jun 24, 2021

@abaicus can you review the CSS changes here please.

Copy link
Collaborator

@abaicus abaicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@selul selul merged commit 107417b into development Jun 29, 2021
@selul selul deleted the fix/single-product-buttons branch June 29, 2021 08:23
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
4 participants