Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Related Posts Exerpt #4129

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

preda-bogdan
Copy link
Contributor

Summary

This was triggered only when also using the Author meta.

References: #4011

This was a bug introduced with the changes from #4011 the wp_reset_postdata would reset the secondary query back to the main query. It should not be required and have both issues fixed without the need for resetting the post data.

Will affect the visual aspect of the product

NO

Screenshots

Related Posts displaying correct excerpt

image

Sticky Post Author Name

image

Test instructions

Test Related Posts Exerpt

  1. Enable the related posts section on the single post
  2. Add two, three, or more articles in the same category
  3. Check a post.
  4. Each post should display the correct excerpt, previously it would show the excerpt from the main post.
  5. Check the Read More link as well.
  6. As a last step use the testing from fix: set correct post context for author hooks #4011 #4037 to ensure no regression is introduced and the issue remains fixed.

Check before Pull Request is ready:

Closes Codeinwp/neve-pro-addon#2656.

@preda-bogdan preda-bogdan added the pr-checklist-skip Allow this Pull Request to skip checklist. label Nov 2, 2023
@pirate-bot pirate-bot added pr-checklist-complete The Pull Request checklist is complete. (automatic label) labels Nov 2, 2023
@pirate-bot
Copy link
Collaborator

Plugin build for e419e59 is ready 🛎️!

Copy link
Member

@HardeepAsrani HardeepAsrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix and adding context for me and QA team.

@irinelenache
Copy link
Contributor

@preda-bogdan Tested and everything works fine regarding this issue and #4011

@preda-bogdan preda-bogdan merged commit 3a3a6a6 into development Nov 28, 2023
19 checks passed
@preda-bogdan preda-bogdan deleted the fix/related_posts_excerpt branch November 28, 2023 08:49
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.7.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants