Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add global colors as color presets in beaver #2328

Closed
selul opened this issue Nov 27, 2020 · 2 comments
Closed

add global colors as color presets in beaver #2328

selul opened this issue Nov 27, 2020 · 2 comments
Assignees
@cristian-ungureanu
Labels
doc-needed This issue requires documentation updates or additions once it has been completed. enhancement Request to improve or optimize an existing feature or functionality in the project released Indicate that an issue has been resolved and released in a particular version of the product.

Comments

@selul
Copy link
Contributor

selul commented Nov 27, 2020

Description:

https://docs.wpbeaverbuilder.com/beaver-builder/styles/colors/add-a-color-palette-to-the-beaver-builder-editor
@selul selul assigned cristian-ungureanu and unassigned abaicus Mar 7, 2021
@selul selul added the enhancement Request to improve or optimize an existing feature or functionality in the project label Mar 17, 2021
cristian-ungureanu pushed a commit that referenced this issue Apr 20, 2021
feat: add global color as presets in beaver builder [#2328]
e6ac9b3
@cristian-ungureanu cristian-ungureanu mentioned this issue Apr 20, 2021
Merged
cristian-ungureanu pushed a commit that referenced this issue Apr 20, 2021
chore: make sure there are no duplicates [#2328]
38a2d2a
@cristian-ungureanu
Copy link
Contributor

cristian-ungureanu commented Apr 20, 2021 •
edited
Loading

@selul, as we've talked about on slack, I'm not able to implement this due to Beaver Builder's implementation. They only support RGB and hex value and they sanitize anything else. On the front-end, they take the control data, change it to RGB, and then they use it.
I've added a feature request on their repo but they already had a similar one since 1 Oct 2020 and nothing happened.
Right now, all I was able to do is to take the CSS var color and add that color to their presets. It's not global. if you change a color in the customizer it won't change where you've used it in Beaver, but at least users will have the usual colors of their sites somewhere more accessible.

@selul selul added the doc-needed This issue requires documentation updates or additions once it has been completed. label Apr 26, 2021
@selul selul mentioned this issue Apr 27, 2021
Merged
abaicus added a commit that referenced this issue Apr 28, 2021
@abaicus
release: new version
018c07b 
- [Fix] Dropdowns (input select) in specific widgets do not respect global form styles  - #2581
- [Fix] Wrong text color inheritance in group blocks with color settings - #2540
- [Fix] Cart icon opening behavior when positioned on the left side of header - #2468
- [Fix] Improve accessibility for external links in the Neve page and customizer
- [Fix] Color Picker Modal remains open even after switching Color Palettes - #2628
- [Fix] Increase Templates Cloud visibility on Neve options page
- [Fix] Infinite scroll loads posts of incorrect language - #2696
- [Feat] Add global color as presets in beaver builder - #2328.
- [Feat] Ignore lazyload on above the fold images 
- [Feat] implement next page links for infinite scroll
- [Feat] Adds compatibility for meta association on template import/export for Neve Cloud
pirate-bot added a commit that referenced this issue Apr 28, 2021
@pirate-bot
chore(release): 2.11.2
c3f5670 
##### [Version 2.11.2](v2.11.1...v2.11.2) (2021-04-28)

- [Fix] Dropdowns (input select) in specific widgets do not respect global form styles  - #2581
- [Fix] Wrong text color inheritance in group blocks with color settings - #2540
- [Fix] Cart icon opening behavior when positioned on the left side of header - #2468
- [Fix] Improve accessibility for external links in the Neve page and customizer
- [Fix] Color Picker Modal remains open even after switching Color Palettes - #2628
- [Fix] Increase Templates Cloud visibility on Neve options page
- [Fix] Infinite scroll loads posts of incorrect language - #2696
- [Feat] Add global color as presets in beaver builder - #2328.
- [Feat] Ignore lazyload on above the fold images
- [Feat] implement next page links for infinite scroll
- [Feat] Adds compatibility for meta association on template import/export for Neve Cloud
@pirate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 2.11.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Apr 28, 2021
@selul selul closed this as completed Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cristian-ungureanu cristian-ungureanu

Labels
doc-needed This issue requires documentation updates or additions once it has been completed. enhancement Request to improve or optimize an existing feature or functionality in the project released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@selul @cristian-ungureanu @abaicus @pirate-bot