-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Main group #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good, we can move this to QA for testing.
@mghenciu On desktop everything looks ok. I'm wondering if the way it now looks on mobile is ok ( with some sections that don't have any left/right padding ). |
Thank you Rodica for checking so promptly. @JohnPixle , apparently using Inner blocks use content width with Neve FSE - there's also a visual issue when previewing Core Styles (attached): Now, I did some testing with Spectra one (which doesn't uses one main group) and with Frost (which has a main group). And what I noticed in case of Frost, is that they use Inner blocks use content width with all groups, in some they even have values; additionally they use custom padding on the sides - which we don't. Added a video below with Frost: Screen.Recording.2023-07-13.at.16.37.45.movLet me know what you think. |
Summary
This fixes the issue where the main group for all the templates, has some padding on the sides in the editor.
After the fix, there should be no padding in the Editor.
Will affect visual aspect of the product
YES, In the Editor only
Screenshots
Test instructions
Closes #54 .