Fixed scheduler time issue

[girishpanchal30]

Summary

Improve scheduler util class

Check before Pull Request is ready:

• I have written a test and included it in this PR
• I have run all tests and they pass
• The code passes when running the PHP CodeSniffer
• Code meets WordPress Coding Standards for PHP, HTML, CSS and JS
• Security and Sanitization requirements have been followed
• I have assigned a reviewer or two to review this PR (if you're not sure who to assign, we can do this step for you)

Closes #827

[pirate-bot]

Plugin build for a4db08f is ready 🛎️!

• Download build

[vytisbulkevicius]

@girishpanchal30 @HardeepAsrani,

I installed These PRs:
Pro: https://github.com/Codeinwp/feedzy-rss-feeds-pro/pull/809
Lite: #1043

And manually aplied this fix from current PR.

The behavior changed that now I don't see import job next run time at all:

And running feedzy_cron Event:

Doesn't trigger the import jobs:

Does it work for you?

[HardeepAsrani]

@vytisbulkevicius Can you check now?

[selul]

@girishpanchal30 @vytisbulkevicius @HardeepAsrani this has already been fixed by me here 21e3b69, which is on dev.

Also this was not fixing the inconsistency with is_scheduled function @HardeepAsrani, the original method you developed is returning either true false or a timestamp based on the environment, it should return only false or a timestamp.

[girishpanchal30]

@selul @HardeepAsrani

it should return only false or a timestamp.

The get_next method returns a timestamp if a scheduled job is found; otherwise, it returns false. Refer to the diff below for details.

 	public static function is_scheduled( string $hook, array $args = array() ) {
-		if ( function_exists( 'as_has_scheduled_action' ) ) {
-			return as_has_scheduled_action( $hook, $args );
-		}
-
-		if ( function_exists( 'as_next_scheduled_action' ) ) {
-			// For older versions of AS.
-			return as_next_scheduled_action( $hook, $args );
-		}
-
-		return wp_next_scheduled( $hook, $args );
+		return self::get_next( $hook, $args );
 	}

[selul]

yes, thats exactly what is_scheduled is doing atm in my fix.

[girishpanchal30]

@selul

I've checked with dev and it seems the incorrect time is being displayed.

With this PR, the correct time is displayed.

Should I update the is_scheduled method to use the get_next method?

[selul]

We dont need any next method, the is scheduled is enough.

[girishpanchal30]

@selul Okay, In this case, we don’t need to merge this PR. Please close this PR when you can.