Update windows runner in release workflow #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The idea behind the choice of release runners is that the binaries we generate with them should be as compatible as possible. Ideally, this would mean using the oldest still supported version of each OS. |
windows-2016 runners were removed (actions/runner-images#4312)
bertschneider
force-pushed
the
update-release-workflow
branch
from
4343374
to
0b73fc9
Compare
|
Then we should probably also test changes with the oldest versions in addition to the newest ones. I reverted the PR to only update the runner from |
bertschneider
changed the title
fmeum
approved these changes
Apr 28, 2022
|
@bertschneider We could also set up the release flow to run the test suite before actually producing release binaries. The macOS runners are already flaky enough that introducing another factor of 2 to our test matrix could be a net negative. It's very unlikely that tests would break on older OS versions after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
windows-2016runners were removed (actions/runner-images#4312).