Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Lint and Jest Failing #526

Merged
merged 12 commits into from
Jul 27, 2023
Merged

Fix Lint and Jest Failing #526

merged 12 commits into from
Jul 27, 2023

Conversation

kelvinkipruto
Copy link
Contributor

Description

This PR fixes a bug that causes lint and jest to fail.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@vercel
Copy link

vercel bot commented Jul 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codeforafrica ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 1:16pm

@kelvinkipruto kelvinkipruto marked this pull request as ready for review July 27, 2023 08:00
@kelvinkipruto kelvinkipruto changed the title Fix Failing jest Fix Lint and Jest Failing Jul 27, 2023
kilemensi
kilemensi reviewed Jul 27, 2023
View reviewed changes
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

.github/workflows/dependabot_lint_format.yml Outdated Show resolved Hide resolved
packages/eslint-config-commons-ui/package.json Show resolved Hide resolved
@kelvinkipruto
Copy link
Contributor Author

kelvinkipruto commented Jul 27, 2023 •
edited
Loading

@kilemensi Upgrading to prettier 3 introduces many changes when linting is done. Lets do that on a separate PR. This should also upgrade eslint-plugin-prettier

@kilemensi
Copy link
Member

@kilemensi Upgrading to prettier 3 introduces many changes when linting is done. Lets do that on a separate PR

Exactly, you're suppose to resolve the issue before marking it as resolved @kelvinkipruto :

  1. Create an issue to track upgrade of prettier to v3,
  2. Attach it to that convo, and then
  3. Mark the convo as resolved.

kilemensi
kilemensi approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kelvinkipruto kelvinkipruto added this pull request to the merge queue Jul 27, 2023
Merged via the queue into main with commit 7400e5d Jul 27, 2023
3 checks passed
@kelvinkipruto kelvinkipruto deleted the ft/fix-charterafrica-failing-tests branch July 27, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilemensi kilemensi kilemensi approved these changes

@koechkevin koechkevin koechkevin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kelvinkipruto @kilemensi @koechkevin