-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LSP Semantic Token Decoder, Improve LSP-CodeFileDoc Arch #1951
Merged
thecoolwinter
merged 16 commits into
CodeEditApp:main
from
thecoolwinter:feat/lsp-semantics-highlights
Dec 21, 2024
Merged
LSP Semantic Token Decoder, Improve LSP-CodeFileDoc Arch #1951
thecoolwinter
merged 16 commits into
CodeEditApp:main
from
thecoolwinter:feat/lsp-semantics-highlights
Dec 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecoolwinter
added
architecture
language server
Issues or Pull Requests related to language servers.
labels
Dec 19, 2024
thecoolwinter
requested review from
austincondiff,
0xWDG,
matthijseikelenboom,
bombardier200,
FastestMolasses and
tom-ludwig
December 20, 2024 22:23
austincondiff
approved these changes
Dec 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from what I can tell!
FastestMolasses
approved these changes
Dec 21, 2024
0xWDG
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
lspCoordinator
property.LanguageServerFileMap
class to be more extendable as more objects are added for coordinating LSP-document interactions.One small change that went with the second point
AppDelegate
.Related Issues
Checklist
Screenshots
N/A