Fix Navigator Key Navigation Explosion #1803
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue discussed a few different times with the navigator.
To reproduce:
This fixes that bug, and another one I found on the way.
In this PR:
shouldSendSelectionUpdate
in the navigator outline view needed to be set. In these cases, extra selection events were being sent back to the navigator when a tab was opened. This was one of the reasons for the freeze as a few files were being opened over and over again.updateSelection
when receiving a notice that the directory monitor has updated. This was causing an issue where, when revealing a previously unloaded directory, the selection would jump back to the opened tab rather than staying on the folder being opened.Related Issues
Checklist
Screenshots
Screen.Recording.2024-07-09.at.10.26.18.PM.mov