Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made MudSelectExtended IsOpen flag public #469

Merged

Conversation

m-flex
Copy link
Contributor

@m-flex m-flex commented Sep 27, 2024

For discussion:

Made IsOpen property public in MudSelectExtended. This change allows external components or logic to determine whether the dropdown is currently open. It resolves the issue where OnOpen fires too late for a particular use-case (it fires after the content is rendered). By making IsOpen public, you can now directly check the dropdown's state and conditionally render components in the dropdown, ensuring it appears immediately when the dropdown opens.

@mckaragoz
Copy link
Contributor

mckaragoz commented Sep 29, 2024

Understand. But we generally use methods for this, like

public bool GetOpenState()
{
    return _isOpen;
}

If you don't want to set the property, calling via method makes sense for me.

@m-flex
Copy link
Contributor Author

m-flex commented Sep 30, 2024

That makes sense, I've amended the PR as per your suggestions.

@mckaragoz mckaragoz merged commit ac84c83 into CodeBeamOrg:dev Oct 14, 2024
1 check passed
@mckaragoz
Copy link
Contributor

Thanks 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants