614 in memory increases #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
May be used in case someone needs to log RPC exchange on the node side.
When tests/__init__.py is present, pytest adds root directory to PYTHONPATH, so tests can use imports `from dexbot.foo import bar`; otherwise, `pip install -e .` is needed. See doc for details: https://docs.pytest.org/en/latest/goodpractices.html#choosing-a-test-layout-import-rules
This is a workaround for bitshares/python-bitshares#234
Closest order caclulation was a bit wrong which caused an error with new in-memory caclulation logic.
Prevent moving liquidity away from center in valley and neutral modes. Closes: Codaone#444, Codaone#586
Don't allow too small increase steps in mountain mode. This will reduce number of calculations. Closes: Codaone#585
Because we're now calculating increased orders in memory, it's a good idea to reduce min_increase_factor to allow more smooth distribution of profits.
Some tests were broken after increase logic related changes, this fixes them.
test_increase_order_sizes_neutral_smaller_closest_orders is working if some approximation allowed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #614 for details