Staggered orders slope modes and refactor #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a code otimization. Get rid of code doubling for buy and sell orders.
It's not really needed.
This is needed to be able to place orders in non-blocking mode.
Reduce code doubling by using similar methods for base and quote allocation and order placement.
Increase order only whether it's amount is differ from closer order by 50% of increment. This will reduce allocation rounds drastically.
We need to keep several balance "snapshots" across maintenance runs to be able to use triggers based on these changes.
Whether we are in bootstrap mode, balance allocations should happen at every maintenance. Whether they are not happen and balances keeping unchanged, we may assume that we actually not bootstrapping but just working after bot restart. Thus, we may safely turn bootstrap off.
When we have imbalanced sides, and partially filled orders on both sides, and then one order gets fully filled, we may come into situation where we cannot place any new orders because available balance may be not enough nor for full-sized order, neighter for limited by opposite side. So, as a workaround, allow placing of partial orders. This will not introduce any harm because spread will be `spread - increment`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.