Preserve --configfile when running cli.py configure
#279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitphage
force-pushed
the
preserve-configfile-when-configure
branch
from
c2f55aa
to
c86e6a9
Compare
mikakoi
reviewed
Aug 17, 2018
dexbot/basestrategy.py
Outdated
| @@ -158,7 +158,7 @@ def __init__( | |||
| if config: | |||
| self.config = config | |||
| else: | |||
| self.config = config = Config.get_worker_config_file(name) | |||
| self.config = config = Config.get_worker_config_file(name, path=config.config_file) | |||
There was a problem hiding this comment.
Can't reference config here since it's None
There was a problem hiding this comment.
You're right, just passing config is enough, updated a PR.
bitphage
force-pushed
the
preserve-configfile-when-configure
branch
from
c86e6a9
to
965dc48
Compare
@mikakoi you're right, just passing |
When editing a worker Basestrategy reads worker config but it used default config path. Fix this by passing correct config.
bitphage
force-pushed
the
preserve-configfile-when-configure
branch
from
965dc48
to
7b6d218
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing a worker Basestrategy reads worker config but it used
default config path. Fix this by passing correct config path.