Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pkg_resources to allow auto-discovery of third-party strategies #277

Merged
merged 1 commit into from
Aug 17, 2018

Conversation

ihaywood3
Copy link

this allows strategies to be published in external packages and made available via pip
these can then be found and presented to the user during configuration

@@ -57,3 +58,26 @@ def initialize_orders_log():

if not file:
logger.info("worker_name;ID;operation_type;base_asset;base_amount;quote_asset;quote_amount;timestamp")

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing the try/except test inside the find_external_strategies function would make this a bit more readable, don't you think?

@MarkoPaasila
Copy link
Collaborator

This seems like an awesome idea. Did you have any other ideas on how to distribute strategies? I am all for this, but just wanted to ask, as I myself haven't considered this at all, and am not familiar with all different methods.

@ihaywood3
Copy link
Author

ihaywood3 commented Aug 16, 2018 via email

@mikakoi mikakoi merged commit 99e2b14 into Codaone:master Aug 17, 2018
@PermieBTS
Copy link
Collaborator

This issue has been merged..

#327 has been closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants