BitsharesOrderEngine and BitsharesPriceFeed inconsistent attributes

[bitphage]

BitsharesOrderEngine uses attributes which are not defined in __init__ (or elsewhere):

• self.account
• self.market
• self.worker

This means methods which uses these attrs are broken on standalone BitsharesOrderEngine. Now we're don't noticing this because the only user of BitsharesOrderEngine is StrategyBase. All these attrs defined inside StrategyBase.

[bitphage]

BitsharesPriceFeed:

• self.market

[bitphage]

I think it's a good idea to have this fixed after or at the same time as merging tests for BitsharesOrderEngine and BitsharesPriceFeed.

[thehapax]

Yep, we are aware of that. Adding @bitProfessor to the conversation

[thehapax]

Will fix this on next set of pulls.

[bitProfessor]

I think it's a good idea to wait until the order engine is updated to the devel branch.

[bitphage]

This issue still wasn't addressed properly, looks like without tests it's hard to detect was the fix right or not.

BitsharesOrderEngine in __init__ sets self.account = account while it's still overridden in StrategyBase by property def account(self).

[thehapax]

I think it's a good idea to wait until the order engine is updated to the devel branch.
it is now merged into the devel @bitProfessor

@bitfag perhaps we should remove all overriding properties in StrategyBase, is this what you mean?

[thehapax]

@bitfag i made changes, see https://github.com/thehapax/DEXBot/tree/596-properties

[bitphage]

Not sure, I'd rather wait for tests to clearly see everything working as it should.