Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support walltime runs with divan #66

Merged
merged 8 commits into from
Feb 5, 2025
Merged

Support walltime runs with divan #66

merged 8 commits into from
Feb 5, 2025

Conversation

art049
Copy link
Member

@art049 art049 commented Feb 4, 2025

Related changes on our divan's fork https://github.com/CodSpeedHQ/divan : nvzqz/divan@main...CodSpeedHQ:divan:main

  • feat(divan_compat): add divan_compat initial implementation
  • chore(vscode): fix rust-analyzer config
  • feat: expose a collection entrypoint usable within walltime integrations
  • fix(cargo-codspeed): properly forward stdout compiler messages
  • feat(cargo-codspeed): support walltime runs from with cargo-codspeed

@art049 art049 force-pushed the cod-526-build-and-find-walltime-entrypoint-with-divan branch 3 times, most recently from 02c68f6 to 4c33f6d Compare February 4, 2025 14:53
adriencaccia
adriencaccia requested changes Feb 4, 2025
View reviewed changes
crates/cargo-codspeed/Cargo.toml Show resolved Hide resolved
crates/cargo-codspeed/src/run.rs Outdated Show resolved Hide resolved
@art049 art049 force-pushed the cod-526-build-and-find-walltime-entrypoint-with-divan branch 3 times, most recently from 5acf802 to 94a1739 Compare February 4, 2025 17:36
@art049 art049 requested a review from adriencaccia February 4, 2025 17:41
@art049 art049 force-pushed the cod-526-build-and-find-walltime-entrypoint-with-divan branch from 209374e to ea3817d Compare February 4, 2025 17:46
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 4, 2025 •
edited
Loading

CodSpeed Walltime Performance Report

Congrats! CodSpeed is installed 🎉

🆕 2 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks
  • fibo_100 (3.6 µs)
  • fibo_500 (3.6 µs)

GuillaumeLagrange
GuillaumeLagrange requested changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cf comments, I did not go deep into the divan_compat code. I'll look into the CI issue tomorrow morning 😎

crates/cargo-codspeed/src/build.rs Show resolved Hide resolved
crates/cargo-codspeed/src/build.rs Show resolved Hide resolved
crates/cargo-codspeed/src/app.rs Show resolved Hide resolved
crates/cargo-codspeed/src/run.rs Outdated Show resolved Hide resolved
crates/cargo-codspeed/src/run.rs Outdated Show resolved Hide resolved
crates/cargo-codspeed/src/walltime_results.rs Show resolved Hide resolved
crates/codspeed/src/walltime.rs Show resolved Hide resolved
@art049 art049 force-pushed the cod-526-build-and-find-walltime-entrypoint-with-divan branch from ea3817d to 677cb60 Compare February 5, 2025 13:06
@art049 art049 merged commit 677cb60 into main Feb 5, 2025
4 of 5 checks passed
@art049 art049 deleted the cod-526-build-and-find-walltime-entrypoint-with-divan branch February 5, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeLagrange GuillaumeLagrange GuillaumeLagrange requested changes

@adriencaccia adriencaccia Awaiting requested review from adriencaccia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@art049 @GuillaumeLagrange @adriencaccia