Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo codspeed build doesn't build virtual manifest #37

Closed
tversteeg opened this issue Mar 22, 2024 · 3 comments · Fixed by #38
Closed

cargo codspeed build doesn't build virtual manifest #37

tversteeg opened this issue Mar 22, 2024 · 3 comments · Fixed by #38

Comments

@tversteeg
Copy link

I'm trying to integrate CodSpeed into this repo which contains a virtual manifest. So the Cargo.toml contains a [workspace] section but the main package is not included in it.

When I run cargo codspeed build I get the following output:

   Collected 1 benchmark suite(s) to build
    Building benchmarks
       Error There are multiple `blit` packages in your project, and the specification `blit` is ambiguous.
Please re-run this command with `-p <spec>` where `<spec>` is one of the following:
  file:///.../blit#0.8.5
  https://github.com/rust-lang/crates.io-index#blit@0.8.5

There's no way to select the main package, which should be selected by default anyway.

@adriencaccia
Copy link
Member

Hey @tversteeg, thanks for the issue!

I managed to reproduce the error investigating with your repository.

The root cause is not due to the virtual manifest, but rather tied to the fact that blit is dependent on itself, because of its dependency pixel-game-lib which has blit as a dependency.

I submitted a PR with a fix.

@tversteeg
Copy link
Author

Thanks for finding and resolving that @adriencaccia, that must not have been straightforward!

@adriencaccia
Copy link
Member

@tversteeg The fix is available in https://github.com/CodSpeedHQ/codspeed-rust/releases/tag/v2.4.1, let me know if that works for you 😉
Thanks again for the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants