Support comments attribute in all build phases, groups and targets. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xcode 2 and 3 used to have a comments attribute almost everywhere. I have found instances of comments in: - PBXShellScriptBuildPhase - PBXCopyFilesBuildPhase - PBXNativeTarget - PBXApplicationTarget - PBXLibraryTarget - PBXAggregateTarget - PBXGroup
I should actually write and *build* the test before commiting.
|
Looks reasonable. Would you like push access to directly commit patches you feel confident about? |
fabiopelosin
added a commit
that referenced
this pull request
Feb 9, 2013
Support comments attribute in all build phases, groups and targets.
|
Thanks Fabio, already have push access. The confidence is what’s I’m not sure about :D |
Oh, yes... I thought I've checked.
Yes if in doubt opening a pull is much better. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode 2 and 3 used to have a comments attribute almost everywhere. I have
found instances of comments in:
Seems that Xcode 4 doesn't remove those comments, so supporting them is nice for people with old projects being converted to CocoaPods.
A search in Google for "filetype:pbxproj comments" gives you some of this results.
Fixes CocoaPods/CocoaPods#696