Change return value of adding system framework

[keith]

Previously it looked like this function was intending to return a file
reference of the newly created framework, but instead it was returning
the original array of strings. This change returns the array of file
references so consumers can manipulate them as needed.

[keith]

It doesn't look like CP uses the return value from this function anywhere, so no other changes are required. But this is a breaking change so I'm not sure if we want to do this or not. If we do I'll add a CHANGELOG entry.

[keith]

If this behavior is desired I'll have to update the docstrings as well

[supermarin]

@keith why is this a breaking change?

[keith]

I guess it's not, I thought that it was intentionally returning the input array of strings, but that's actually just a side effect from ruby I guess, according to the docstring.

[keith]

I got tricked by the ref at the bottom of the each into thinking it was trying to return that.

[segiddins]

👍🏻 with a changelog entry

[alloy]

The documented return type was void, so nobody should have been expecting a stable return value before. So this is not a breaking change 👍

[keith]

🎉

[alloy]

It looks like the ref at the bottom was left-over from previous code that did indeed return the reference 092a125#diff-adc2f4667b1ea4b75e763b2aa6cd2b30L146.

[supermarin]

@keith please update documentation return type

[keith]

Updated. Would love a second look!