Switch from unmaintained colored to maintained colored2 #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
It's possible that colored2 doesn't support ruby 2.0? |
|
Hrm, doesn't imply it - https://github.com/kigster/colored2/blob/master/colored2.gemspec#L20 |
|
Ah I didn't realise you needed support for both, will investigate, I'm sure we can add that back in |
|
Oh you already did it, nice! |
|
:D I had looked at doing this for danger before, but needed a push |
|
Updated to require version |
endocrimes
approved these changes
Jan 30, 2017
|
This is great, thanks! |
|
Other places we need this: cork, cocoapods, (danger) |
This was referenced Jan 30, 2017
This was referenced May 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The colored gem hasn't seen any activity in over 7 years, colored2 is a maintained fork, more details: https://libraries.io/rubygems/colored2