Fix linting source of a spec for certain URLs

[neonichu]

Fixes linting URLs to local and SSH repos, as reported in #82

[fabiopelosin]

Looks good to me... @kylef?

[kylef]

Looks good.

Couple of things from Rubycopy:

Offenses:
lib/cocoapods-core/specification/linter.rb:336:28: C: Do not use :: for method calls.
          if git =~ /^#{URI::regexp}$/
                           ^^
lib/cocoapods-core/specification/linter.rb:339:15: C: Avoid more than 3 levels of block nesting.
              unless git.end_with?('.git')
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/cocoapods-core/specification/linter.rb:342:15: C: Avoid more than 3 levels of block nesting.
              unless git_uri.scheme == 'https'
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
35 files inspected, 3 offenses detected
RuboCop failed!

[fabiopelosin]

This can be:

return unless git =~ /^#{URI::regexp}$/

[fabiopelosin]

And URI::regexp cab be converted to URI.regexp

[neonichu]

Will change those, thanks. 🍻

[fabiopelosin]

Thank you for contributing man... and finally don't forget that even this repo gained a changelog recently 😄 (I love changelogs!)

[neonichu]

Makes a much cleaner diff as well :)

[neonichu]

So with the new Core CHANGELOG, do we still update the main one for merged PRs?

[fabiopelosin]

Ace! I check all the changelogs and port the relevant entries (this is one) manually before a release... however if you want to submit a pull request that will be very welcome 🍷

[fabiopelosin]

I'm waiting for Travis and the I will merge!

[neonichu]

Sure will, trying to get to the first line on http://cocoapods.org/about contributors list ;)

[orta]

Hah! So bold!

[fabiopelosin]

You can do much better: you can get before @supermarin 💥!

[x2on]

👍 Please make also a new release of CocoaPods soon :)

[dsexton]

👍 Please make also a new release of CocoaPods soon :)

👍

[fabiopelosin]

Ace thanks!

[neonichu]

Sorry for screwing it up in the first place.

[fabiopelosin]

released as CocoaPods 0.31.1

[fabiopelosin]

@neonichu not big deal, the important is that we fixed it... also thanks for the amazing number of contributions in the Bash!

[alloy]

@neonichu No worries, man. These types of issues are only fixed by either knowing all issues upfront or finding out by putting it out into the real world. Now we know and we have the tests, so, yay!

[fabiopelosin]

The important is how fast you stand up after you fall down!

[neonichu]

You guys are too nice. 💖

[x2on]

Thank you - that was really fast!

Am Dienstag, 1. April 2014 schrieb Fabio Pelosin :

released as CocoaPods 0.31.1

Reply to this email directly or view it on GitHubhttps://github.com//pull/84#issuecomment-39214893
.

[Superbil]

@neonichu Thank you, you fix it so fast.