Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes exception when git tag is a Version #72

Merged
merged 1 commit into from
Mar 29, 2014

Conversation

joelparsons
Copy link
Contributor

This fixes CocoaPods/CocoaPods#1721

Now if someone writes

     s.source = { :git => "https://github.com/DDBen/pods.git", :tag => s.version }

in their pod spec its going to succeed instead of fail with a stack trace.

cocoapodsbugbash

@joshkalpin
Copy link
Member

👍 Can you make sure you update the changelog on the main cocoapods repo?

@joshkalpin
Copy link
Member

For reference: https://github.com/CocoaPods/CocoaPods/blob/master/CHANGELOG.md. Should be updated with a proper section now

joshkalpin pushed a commit that referenced this pull request Mar 29, 2014
Fixes exception when git tag is a Version
@joshkalpin joshkalpin merged commit 6af9a00 into CocoaPods:master Mar 29, 2014
Ashton-W pushed a commit to Ashton-W/Core that referenced this pull request Nov 2, 2015
Fixes exception when git tag is a Version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoMethodError - undefined method `include?' for <Pod::Version version=1.0.0>:Pod::Version
2 participants