Skip to content

Commit

Permalink
Merge pull request #71 from dlackty/require-arc
Browse files Browse the repository at this point in the history
Check requires_arc set explicitly in podspec
  • Loading branch information
alloy committed Mar 29, 2014
2 parents 8898876 + 32a2529 commit 16b64c6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion lib/cocoapods-core/specification/linter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ def validate_file_patterns
# @todo remove in 0.18 and switch the default to true.
#
def check_tmp_arc_not_nil
if consumer.requires_arc.nil?
if consumer.spec.attributes_hash["requires_arc"].nil?
warning "A value for `requires_arc` should be specified until the " \
"migration to a `true` default."
end
Expand Down
4 changes: 1 addition & 3 deletions spec/specification/linter_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -370,9 +370,7 @@ def message_should_include(*values)
message.should.include('spec is empty')
end

xit "requires that the require_arc value is specified until the switch to a true default" do
# TODO the default value is invalidating this test
consumer = @spec.consumer(:ios)
it "requires that the requires_arc value is specified explcitly until the switch to a true default" do
@spec.requires_arc = nil
@linter.lint
message = @linter.results.first.message
Expand Down

0 comments on commit 16b64c6

Please sign in to comment.