Do not force include master spec repo if plugin sources are provided #7033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amorde
commented
Sep 14, 2017
| @@ -155,6 +155,7 @@ def resolve_dependencies | |||
| validate_build_configurations | |||
| clean_sandbox | |||
| end | |||
| analyzer | |||
There was a problem hiding this comment.
Returning this here solely to make it easier to test. I'm open to other ideas on a better way to get access to the analyzer
amorde
commented
Sep 14, 2017
|
|
||
| it 'includes sources from source provider plugins' do | ||
| plugin_name = 'test-plugin' | ||
| Pod::HooksManager.register(plugin_name, :source_provider) do |context, options| |
There was a problem hiding this comment.
This hook was lingering beyond the scope of this test. Only myself to blame since I'm the one who originally wrote this code, hah
|
I think this is good with |
|
I think it's the changelog entry rather than Rubocop, will double check |
dnkoutso
approved these changes
Sep 14, 2017
|
Great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5306
Noticed this issue still open so thought I'd take a stab at it. I am interested if this is still a desired change, as it could possibly break some projects that were relying on master being included automatically