Fix pod search when the silent flag is enabled

[joshkalpin]

Fixes #1431. Not sure if this is the best way to fix it, but I don't see why search would ever need a silent flag anyway.

[alloy]

I think this is acceptable, but it would be nice to remove the option from the options list too. E.g. something like:

      def self.options
        [
          ["--full",  "Search by name, summary, and description"],
          ["--stats", "Show additional stats (like GitHub watchers and forks)"],
          ["--ios",   "Restricts the search to Pods supported on iOS"],
          ["--osx",   "Restricts the search to Pods supported on OS X"]
        ].concat(super.reject { |option, _| option == '--silent' })
      end

(In the block parameter list, the _ parameter would be the option description, I usually use _ to signify it’s not relevant to what the block does.)

[fabiopelosin]

Looks great to me. We need to fix the validation on Travis and then we can merge this.

[fabiopelosin]

Opss missed @alloy's comment which makes a lot of sense.

[joshkalpin]

@alloy I didn't even know you could do that.

[joshkalpin]

@irrationalfab and @alloy if it looks good I'll merge :)

[alloy]

[alloy]

👍

[fabiopelosin]

👍