This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
Plugin print preview map demo #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this check, adding a layer from the plugin print demo would sometimes result in an error. This is either a result of upgrading to 3.25 or an existing bug that wasn't surfaced previously.
|
Taking a look at this! |
|
I see the map in the modal:
I think we should also adjust the modal's height to make it so the map and the print button are visible without having to scroll. |
|
Cool. Will do. |
|
Pushed a fixup commit that makes the modal a bit taller. You still need to scroll to see all of the content because if the modal was any larger, it would be cut-off on my 13" laptop screen. Relatedly, there is an issue to improve the modal sizing: #1042 |
|
|
|
👍 Cool, this is working well. |
|
Thanks for the review! |
Add a print preview map to the identify point plugin. This serves as a demo to plugin developers of how to add a print preview map to the plugin print workflow. Also, make some adjustments to the optional print images and map size for the plugin to compensate for the new sizing units. Refs #1103
caseycesari
force-pushed
the
cpc/print-preview-demo
branch
from
8254451 to
7407db7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add a print preview map to the identify point plugin. This serves as a demo to plugin developers of how to add a print preview map to the plugin print workflow.
Also, make some adjustments to the optional print images and map size for the plugin to compensate for the new sizing units.
Connects #1103
Demo
Testing Instructions