Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Opening the map utils plugin closes open sidebar plugin #734

Closed
caseycesari opened this issue Nov 16, 2016 · 4 comments
Closed

Opening the map utils plugin closes open sidebar plugin #734

caseycesari opened this issue Nov 16, 2016 · 4 comments
Assignees

Comments

@caseycesari
Copy link
Contributor

caseycesari commented Nov 16, 2016

I think the sidebar plugin should stay open.

To reproduce:

  • Activate the regional planning plugin or another sidebar plugin.
  • Click the map utils button.
  • The regional planning plugin will close.

image

image

@kdeloach
Copy link
Contributor

This is actually by design. You can reproduce this behavior in production by opening any sidebar plugin and then activating the measure plugin.

@caseycesari
Copy link
Contributor Author

Ah, got it. We may want to change it so that it closes only if you select one of the map util plugins. Currently it closes the sidebar plugin even if you just click the map utils button to open the menu.

@caseycesari caseycesari removed the bug label Nov 16, 2016
@kdeloach
Copy link
Contributor

Yeah, I tried really hard to figure out a way to open that menu without "activating" the plugin but the API just isn't flexible enough to allow this. I thought setting the plugin option closeOthersWhenActive to true would do the trick but it had some negative side effects. Definitely agree the current behavior is counter intuitive.

@mmcfarland mmcfarland added the 1 label Nov 17, 2016
@caseycesari caseycesari added in progress and removed 1 labels Nov 28, 2016
@caseycesari caseycesari self-assigned this Nov 28, 2016
@caseycesari caseycesari added the + label Nov 28, 2016
@caseycesari
Copy link
Contributor Author

I spent a little bit of time looking into this, and I think @kdeloach is correct. There's not a good way to do this without some changes to the plugin API.

@caseycesari caseycesari added 1 and removed in progress labels Nov 28, 2016
@caseycesari caseycesari removed their assignment Nov 28, 2016
@caseycesari caseycesari removed the + label Nov 28, 2016
@kdeloach kdeloach self-assigned this Dec 12, 2016
kdeloach added a commit to kdeloach/GeositeFramework that referenced this issue Dec 12, 2016
Fixes various UX issues with map_utils plugin by integrating it into the
framework core.

Changes:

* Replace custom dropdown with Bootstrap widget
* Merge CSS, templates, and locale files
* Simplify map_utils commands

Connects CoastalResilienceNetwork#734
Connects CoastalResilienceNetwork#738
kdeloach added a commit to kdeloach/GeositeFramework that referenced this issue Dec 12, 2016
Fixes various UX issues with map_utils plugin by integrating it into the
framework core.

Changes:

* Replace custom dropdown with Bootstrap widget
* Merge CSS, templates, and locale files
* Simplify map_utils commands

Connects CoastalResilienceNetwork#734
Connects CoastalResilienceNetwork#738
kdeloach added a commit to kdeloach/GeositeFramework that referenced this issue Dec 12, 2016
Fixes various UX issues with map_utils plugin by integrating it into the
framework core.

Changes:

* Replace custom dropdown with Bootstrap widget
* Merge CSS, templates, and locale files
* Simplify map_utils commands

Connects CoastalResilienceNetwork#734
Connects CoastalResilienceNetwork#738
kdeloach added a commit to kdeloach/GeositeFramework that referenced this issue Dec 12, 2016
Fixes various UX issues with map_utils plugin by integrating it into the
framework core.

Changes:

* Replace custom dropdown with Bootstrap widget
* Merge CSS, templates, and locale files
* Simplify map_utils commands

Connects CoastalResilienceNetwork#734
Connects CoastalResilienceNetwork#738
kdeloach added a commit to kdeloach/GeositeFramework that referenced this issue Dec 12, 2016
Fixes various UX issues with map_utils plugin by integrating it into the
framework core.

Changes:

* Replace custom dropdown with Bootstrap widget
* Merge CSS, templates, and locale files
* Simplify map_utils commands

Connects CoastalResilienceNetwork#734
Connects CoastalResilienceNetwork#738
kdeloach added a commit to kdeloach/GeositeFramework that referenced this issue Dec 12, 2016
Fixes various UX issues with map_utils plugin by integrating it into the
framework core.

Changes:

* Replace custom dropdown with Bootstrap widget
* Merge CSS, templates, and locale files
* Simplify map_utils commands

Connects CoastalResilienceNetwork#734
Connects CoastalResilienceNetwork#738
kdeloach added a commit to kdeloach/GeositeFramework that referenced this issue Dec 13, 2016
Fixes various UX issues with map_utils plugin by integrating it into the
framework core.

Changes:

* Replace custom dropdown with Bootstrap widget
* Merge CSS, templates, and locale files
* Simplify map_utils commands

Connects CoastalResilienceNetwork#732
Connects CoastalResilienceNetwork#734
Connects CoastalResilienceNetwork#738
kdeloach added a commit to kdeloach/GeositeFramework that referenced this issue Dec 15, 2016
Fixes various UX issues with map_utils plugin by integrating it into the
framework core.

Changes:

* Replace custom dropdown with Bootstrap widget
* Merge CSS, templates, and locale files
* Simplify map_utils commands
* Add intro popup to measure command
* Add delete button to measure command

Connects CoastalResilienceNetwork#732
Connects CoastalResilienceNetwork#734
Connects CoastalResilienceNetwork#738
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants