use proper dataformats for event, run, lumi #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm nervous about just pushing this since I think it might mess up some downstream code, especially anything that relies on event matching. Does anyone have any thoughts? |
|
Hey @richard-cms this is pretty much what is there in the hcal noise tree https://github.com/CmsHI/cmssw/blob/forest_CMSSW_7_5_5_patch4/HeavyIonsAnalysis/JetAnalysis/src/HiHcalAnalyzer.cc#L52 |
|
It's wrong in the HcalNoise tree as well (the unsigned part is important). It's just going to be painful if we have to deal with older forests with one definition and newer forests with the newer definition at the same time. |
harmonicoscillator
pushed a commit
that referenced
this pull request
Dec 3, 2015
use proper dataformats for event, run, lumi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the whitespace changes.