Iscsi target stop in failed resource state #1316
Open
+26
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lation does not work if more than one backing store exist. Switched to discovery by OCF_RESOURCE_INSTANCE which should be unique
|
Can one of the admins verify this patch? |
|
This pull request is only for commit f2f551c. |
|
ok to test |
1 similar comment
|
ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the LUN resource is in failed state e.g. the backing store file or device is not available, this prevented targetcli cleanup.
When the backing store file or device comes back online and admin issues resource cleanup this resulted in targetcli config being partially present and start operation failing.
I'm not sure why this block is there in the first place because subsequent code is prepared for partial targetcli config status.
Is there a reason for stop operation to return success every time the resource is not-running?