Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apache: create APACHE_RUN_DIR and APACHE_LOCK_DIR if they're defined #1158

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

apache: create APACHE_RUN_DIR and APACHE_LOCK_DIR if they're defined #1158

wants to merge 1 commit into from

Conversation

oalbrigt
Copy link
Contributor

@krig
Copy link
Contributor

krig commented Jun 15, 2018

LGTM

krig
krig reviewed Jun 15, 2018
View reviewed changes
heartbeat/apache Outdated
fi

if [ -n "${APACHE_LOCK_DIR}" ] && [ ! -d "${APACHE_LOCK_DIR}" ]; then
mkdir "${APACHE_LOCK_DIR}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this also be mkdir -p?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I've pushed a new update to fix it.

@oalbrigt oalbrigt force-pushed the apache-run_dir-lock_dir-support branch from 8a4e49a to 3670a78 Compare June 15, 2018 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krig krig krig left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oalbrigt @krig