Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: requirements: remove parallax #1219

Conversation

nicholasyang2022
Copy link
Collaborator

parallax is not a dependency anymore and has already been removed in setup.py. It should also be removed from requirements.txt

parallax is not a dependency anymore and has already been removed in
setup.py. It should also be removed from requirements.txt
@liangxin1300
Copy link
Collaborator

Why codecov failed?

@nicholasyang2022
Copy link
Collaborator Author

Why codecov failed?

We upload 22 reports in each run of the pipeline. Sometimes it exceeds the rate limit of some web API.

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #1219 (6f691cf) into master (cf4a40a) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1219      +/-   ##
==========================================
+ Coverage   52.46%   52.48%   +0.01%     
==========================================
  Files          78       78              
  Lines       25012    25012              
==========================================
+ Hits        13123    13128       +5     
+ Misses      11889    11884       -5     

see 1 file with indirect coverage changes

@nicholasyang2022 nicholasyang2022 merged commit a9d7f26 into ClusterLabs:master Jul 28, 2023
56 checks passed
@nicholasyang2022 nicholasyang2022 deleted the remove_parallax_from_requirement_txt branch August 7, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants