Add back all country support for validating VAT numbers #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n on some tests which failed before
Developers can use http://www.vatcheck.eu/vatcheck.php to validate EU VAT numbers
BenFidge
approved these changes
Dec 19, 2019
There was a problem hiding this comment.
Pulled locally and run tests. all pass:
Test run for D:\Projects\CluedIn\Enricher.VatLayer\test\unit\ExternalSearch.VatLayer.Unit.Tests\bin\Debug\net452\CluedIn.ExternalSearch.VatLayer.Unit.Tests.dll(.NETFramework,Version=v4.5.2)
Build completed.
Test run for D:\Projects\CluedIn\Enricher.VatLayer\test\integration\ExternalSearch.VatLayer.Integration.Tests\bin\Debug\net452\ExternalSearch.VatLayer.Integration.Tests.dll(.NETFramework,Version=v4.5.2)
Microsoft (R) Test Execution Command Line Tool Version 15.9.0
Copyright (c) Microsoft Corporation. All rights reserved.
Microsoft (R) Test Execution Command Line Tool Version 15.9.0
Copyright (c) Microsoft Corporation. All rights reserved.
Starting test execution, please wait...
Starting test execution, please wait...
Total tests: 127. Passed: 127. Failed: 0. Skipped: 0.
Test Run Successful.
Test execution time: 2.5526 Seconds
Total tests: 5. Passed: 5. Failed: 0. Skipped: 0.
Test Run Successful.
Test execution time: 8.1217 Seconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #11
Summary of changes:
European VAT number validation website is very useful for checking VAT numbers.