Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] - Displays an error message when Planex/ADE is down #52

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[WIP] - Displays an error message when Planex/ADE is down #52

wants to merge 3 commits into from

Conversation

gerald-lbn
Copy link
Contributor

Je sais pas si c'est ce qui était attendu pour #25

TODOS:

  • Changer l'url du fichier json
  • Integration de PlanexDown sur le serveur: PR
    Screenshot_1659898203

ignyx
ignyx requested changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@ignyx ignyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start !

locales/fr.json
"docjyj": "Étudiant en 2MIC FAS (2020). Il a ajouté quelques nouvelles fonctionnalités et corrigé des bugs.",
"yohan": "Étudiant en 4IR (2020). Il a aidé à corriger des bug et a proposé quelques idées.",
"docjyj": "Étudiant en 2MIC FAS (2020). Il a ajouté quelques nouvelles fonctionnalités et corrigé des bugs.",
"yohan": "Étudiant en 4IR (2020). Il a aidé à corriger des bug et a proposé quelques idées.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is outdated, consider merging master into this branch

src/utils/Planex.ts Outdated Show resolved Hide resolved
src/components/Screens/PlanexWebview.tsx
@@ -129,7 +130,13 @@ function PlanexWebview(props: Props) {
showControls={props.currentGroup !== undefined}
incognito={true}
/>
{!props.currentGroup ? (
{props.isPlanexDown ? (
<ErrorView
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current behavior is to wait until webview has loaded (showing loading animation) before showing unavailable error message. See getRenderLoading in src/components/Screens/PlanexWebview.tsx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the loading animation already showed until the error/calendar is shown ?

Are you talking about this ?

application-amicale/src/components/Screens/RequestScreen.tsx

Line 29 in aaf72d9

showLoading?: boolean;

@ignyx
Copy link
Contributor

ignyx commented Aug 12, 2022

I can't seem to locate where the changes need to be made, but when pressing the reload button (top-right), the api end-point is not checked again (in case planex has gone back up since first check). ie the reload button doesn't reload

@ignyx
Copy link
Contributor

ignyx commented Nov 23, 2022

When trying to load Planex Screen, without any internet I am met with a infinite loading indicator. Expected behavior would be for a network error message to be shown.

 WARN  Encountered an error loading page {"canGoBack": false, "canGoForward": false,
"code": -2, "description": "net::ERR_INTERNET_DISCONNECTED", "loading": false, 
"target": 659, "title": "", "url": "http://planex.insa-toulouse.fr/"}
Screenshot

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignyx ignyx ignyx requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gerald-lbn @ignyx