Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role: transmissionx #273

Merged
merged 19 commits into from
Oct 26, 2020
Merged

Add role: transmissionx #273

merged 19 commits into from
Oct 26, 2020

Conversation

giosann
Copy link
Contributor

@giosann giosann commented Sep 12, 2020

This adds transmission, my personal favorite torrent client. Capable of handling 20k+ torrents without much trouble even in gui / desktop client.

suggestions and testing welcome

@owine
Copy link
Contributor

owine commented Sep 12, 2020

Out of curiosity, why not just do the tranxmissionx role with the default name in settings being blank which would be a "default" role?

@giosann
Copy link
Contributor Author

giosann commented Sep 12, 2020

Out of curiosity, why not just do the tranxmissionx role with the default name in settings being blank which would be a "default" role?

Well... I don't really have a reason, I just went with it... It's a good idea though.

Removed transmission leaving only transmissionx

@giosann giosann changed the title Add roles: transmission and transmissionx Add role: transmissionx Sep 13, 2020
@giosann giosann marked this pull request as ready for review September 15, 2020 17:55
@giosann
Copy link
Contributor Author

giosann commented Sep 22, 2020

It works fine for me, I've tried it on a somewhat new Cloudbox install and on a completely fresh one.

There is a minor issue but I don't think it's solvable: When the container starts even if the settings.json file has the correct configuration the container will automatically create the /downloads/complete and /downloads/incomplete directories.

https://github.com/linuxserver/docker-transmission/blob/500494ffb3adf482ff0451e1b89c7c225b874544/root/etc/cont-init.d/20-config

I've tested mapping /downloads/ to /mnt/local/downloads/torrents/transmission{role}/ but this creates issues with sonarr because the path mapping does not match.

In my opinion this is minor because it's just an empty folder. I'll note this in the wiki but I think this is mergeable now.

@giosann giosann marked this pull request as draft September 28, 2020 09:44
@giosann giosann marked this pull request as ready for review September 28, 2020 09:45
@saltydk
Copy link
Contributor

saltydk commented Oct 18, 2020

This PR seems like a bit of a mess. Why is the opt folder mounted as

- "/opt/transmission{{ rolename }}:/opt/transmission{{ rolename }}"

And you mount the download folders twice?

@giosann
Copy link
Contributor Author

giosann commented Oct 19, 2020

Well I'm glad it is a bit of a mess and not a complete mess hahaha.

opt is mounted like that because I copied from https://github.com/Cloudbox/Community/blob/develop/roles/transmissionvpn/tasks/main.yml and used the "if it ain't broke, don't fix it" rule.

as for this double mount

      - "/mnt/local/downloads/:/downloads"
      - "/mnt/local/downloads/torrents/transmission{{ rolename }}/watch:/watch"

It is because the container automatically changes the watched folder at each start and sets it to /watch so this is the only solution. See: linuxserver/docker-transmission#100

@saltydk
Copy link
Contributor

saltydk commented Oct 19, 2020

By double mount I meant

volumes: "{{ default_volumes + torrents_downloads_path|default([]) }}"

You define the download mount yet that is already included by the default setup.

@saltydk
Copy link
Contributor

saltydk commented Oct 19, 2020

As far as copying the vpn version that is not a good way of doing things when you're not using the same image.

Copy link
Contributor

@saltydk saltydk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be my suggestion for the role. Take it for a spin?

@giosann
Copy link
Contributor Author

giosann commented Oct 26, 2020

Everything seems to be working fine, both the already in use updated roles and the new ones I've put for testing

@saltydk saltydk merged commit ee96aa1 into Cloudbox:develop Oct 26, 2020
@giosann giosann deleted the develop branch October 27, 2020 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants