Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Express Gateway to the project #11

Closed
wants to merge 3 commits into from
Closed

Add Express Gateway to the project #11

wants to merge 3 commits into from

Conversation

XVincentX
Copy link
Member

Hey — you probably remember me, we met at Node Summit and I've been speaking with Chris about featuring Express Gateway as the API Gateway for the project.

This is just a start — I'd love to iterate more with you on this.

Cheers!

@CLAassistant
Copy link

CLAassistant commented Aug 7, 2018

CLA assistant check
All committers have signed the CLA.

@XVincentX
Copy link
Member Author

//cc @seabaylea @BethGriggs

@XVincentX
Copy link
Member Author

Latest master merged.

@seabaylea
Copy link
Member

Hi @XVincentX. Sorry - I completely missed that you'd raised this PR.

It looks like you've raised a PR to provide an official Helm chart, which is fantastic! Does the deployed gateway support liveness, open tracing and prometheus etc? Are you doing anything to provide annotation based registration of APIs into the gateway?

@XVincentX
Copy link
Member Author

Hey @seabaylea — to answer your questions:

  1. Yeah, we have an official PR for Helm Charts as well as one to make EG part of the official Docker image program. Unfortunately the review times seem to be really high, but I am confident we're almost near the finish line.

  2. The deployed gateway support basic living and readiness probes — although they're not in the way I want. I could employ your library, but I haven't been able to inspect their source code yet (yeah, I do that for almost all the dependencies)

  3. We do, in a certain way — Express Gateway has a plugin architecture so you can basically plug in anything you want, including any Express Middleware of course. Regarding Prometheus, I also wrote an article about that.

  4. To be precise, we do have a plan to write an Ingress Controller for Express Gateway, but as you can see we do have some missing pieces. We'll get there.

I hope that answer your questions. We're not there yet to be completely cloud native but I'm quite sure EG's presence there would drive the roadmap significantly towards that direction.

Have a good one!

@XVincentX
Copy link
Member Author

We have an official Helm chart now.

@XVincentX
Copy link
Member Author

@seabaylea

Is there any update on this?

@gdams
Copy link
Member

gdams commented Sep 21, 2018

ping @seabaylea

@XVincentX
Copy link
Member Author

It seems like the website has been changing since my PR @gdams

I want to make sure the maintainers are going to accept the PR before rebasing.

@XVincentX
Copy link
Member Author

@gdams Any update on this?

@XVincentX XVincentX closed this Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants