Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDO-2649] Kubernetes Optimizer Project #103
[SDO-2649] Kubernetes Optimizer Project #103
Changes from 50 commits
5a066d0
8bce2f2
19f325b
acb0230
1b0cb7c
02ef1d3
6cb0cff
fc44d64
411d2c8
db51661
f0c4bb9
423821f
efa7ceb
60193dc
197d433
f50700e
fa8fd4a
8eb061a
7c60635
b593ab1
31a55fe
7ddb78e
d2dd2c9
8e02f86
5b09c25
187af4d
bbe43fc
7292c25
3867720
da4f915
c58b4f2
5ba759a
53ddb2c
824bb38
8c3b593
1b29659
7fa3c48
3972a60
cbbddaa
1b41fcf
de7e6b7
4500812
a43249e
8247611
485fae9
988a36e
b2fc51f
9c18deb
14c2074
1c21afc
e76377a
64854f6
13d9428
03c2529
6253cd7
b7337cd
3b47c17
d13e30f
6160189
741386b
80d20df
e785c9e
cb826cf
d052fc2
1e87155
b630e7c
3951fd3
23f17f9
92790c6
a08a3b4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the name change now (to something like
cloudhealth-collector-and-optimizer
)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not change this to keep the workflow and instructions the same for customers who are using only collector.
If and when we change this:
since the repo itself is called
cloudhealth
i prefer changing the helm chart tokubernetes-collector
.I prefer this command:
helm install kubernetes-collector .... cloudhealth/kubernetes-collector
tohelm install cloudhealth-collector ....... cloudhealth/cloudhealth-collector
.Don't think we want to change the helm chart name without a wider discussion and announcement. Having
optimizer
in the name might also warrant discussion given most of our customers will be collector only customers.