Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nanoflann to v1.5.5 #105

Merged
merged 2 commits into from
May 5, 2024
Merged

Update nanoflann to v1.5.5 #105

merged 2 commits into from
May 5, 2024

Conversation

rjanvier
Copy link
Member

@rjanvier rjanvier commented May 5, 2024

fix an annoying cmake warning.

@rjanvier rjanvier requested a review from dgirardeau May 5, 2024 21:00
dgirardeau
dgirardeau requested changes May 5, 2024
View reviewed changes
Copy link
Member

@dgirardeau dgirardeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to see what the real changes are (with all these syntax changes). Can you revert them?

src/Kriging.cpp Outdated Show resolved Hide resolved
src/Kriging.cpp Outdated Show resolved Hide resolved
dgirardeau
dgirardeau approved these changes May 5, 2024
View reviewed changes
Copy link
Member

@dgirardeau dgirardeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ah, much more readable indeed

@rjanvier rjanvier merged commit fdf4c0e into master May 5, 2024
16 checks passed
@rjanvier rjanvier deleted the update_nanoflann branch May 5, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgirardeau dgirardeau dgirardeau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjanvier @dgirardeau