updated dependencies and posix expansion for values #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgooch
reviewed
Feb 26, 2024
| @@ -1,6 +1,8 @@ | |||
| module github.com/Cloud-Foundations/keymaster | |||
|
|
|||
| go 1.18 | |||
| go 1.21 | |||
There was a problem hiding this comment.
Do we need to force the most recent version of Go? Is 1.19 sufficient?
There was a problem hiding this comment.
unfortunatelly, the library I chose requires 1.21 (1.22 is the lastest)
rgooch
reviewed
Feb 26, 2024
README.md
Outdated
| @@ -31,7 +31,7 @@ Pre-build binaries (both RPM and DEB) can be found here: [releases page](https:/ | |||
| ### Building from Source | |||
|
|
|||
| #### Prerequisites | |||
| * go >= 1.13 | |||
| * go >= 1.19 | |||
There was a problem hiding this comment.
Should this be 1.21 to be consistent?
rgooch
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.