-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TTS fixes and Readme Updates #43
TTS fixes and Readme Updates #43
Conversation
🔍 Code Review Summary❗ Attention Required: This push has potential issues. 🚨 Overview
🚨 Critical IssuesPerformance (2 issues)1. Disable threading for ONNX WASM runtime to avoid potential issues📁 File: src/libs/transformers/backends/onnx.ts 💡 Solution: Current Code: ['[LINE 158][UPDATED] // Disable threading to avoid potential issues', '[LINE 159][UPDATED] ONNX_ENV.wasm.numThreads = 1;'] Suggested Code: ['[LINE 158][UPDATED] // Disable threading to avoid potential issues', '[LINE 159][UPDATED] ONNX_ENV.wasm.numThreads = 1;'] 2. Use self-hosted WASM files instead of remote CDN📁 File: src/libs/transformers/backends/onnx.ts 💡 Solution: Current Code: ['[LINE 145][UPDATED] ONNX_ENV.wasm.wasmPaths ={', '[LINE 146][UPDATED] wasm: `https://cdn.jsdelivr.net/npm/@huggingface/transformers@${env.version}/dist/ort-wasm-simd-threaded.jsep.wasm`,', '[LINE 147][UPDATED] mjs: `https://cdn.jsdelivr.net/npm/@huggingface/transformers@${env.version}/dist/ort-wasm-simd-threaded.jsep.mjs`,', '[LINE 148][UPDATED]};'] Suggested Code: ['[LINE 145][UPDATED] ONNX_ENV.wasm.wasmPaths ={', '[LINE 146][UPDATED] wasm: `./ort-wasm-simd-threaded.jsep.wasm`,', '[LINE 147][UPDATED] mjs: `./ort-wasm-simd-threaded.jsep.mjs`,', '[LINE 148][UPDATED]};']
Useful Commands
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider implementing the following changes to improve the code.
Deploying browserai-voice-demo with
|
Latest commit: |
fe1a137
|
Status: | ✅ Deploy successful! |
Preview URL: | https://e73b9063.browserai.pages.dev |
Branch Preview URL: | https://41-update-readme-with-kokoro.browserai.pages.dev |
Deploying browserai-chat-demo with
|
Latest commit: |
fe1a137
|
Status: | ✅ Deploy successful! |
Preview URL: | https://b0c43830.browserai-chat-demo.pages.dev |
Branch Preview URL: | https://41-update-readme-with-kokoro.browserai-chat-demo.pages.dev |
Deploying tts-demo with
|
Latest commit: |
fe1a137
|
Status: | ✅ Deploy successful! |
Preview URL: | https://3be7e223.tts-demo.pages.dev |
Branch Preview URL: | https://41-update-readme-with-kokoro.tts-demo.pages.dev |
Update BrowserAI to v1.0.16
Update the BrowserAI library to the latest version and make related changes to the demo applications.
These changes should improve the overall performance and reliability of the demo applications by leveraging the latest BrowserAI features and optimizations.
Original Description
None