Add docker based submission fix #379
Conversation
| @@ -126,6 +127,147 @@ def push(image, phase, url, public, private): | |||
| max_docker_image_size = response.get("max_docker_image_size") | |||
|
|
|||
| docker_image_size = docker_image.__dict__.get("attrs").get("VirtualSize") | |||
| # Prompt for submission details | |||
| if click.confirm("Do you want to include the Submission Details?"): | |||
There was a problem hiding this comment.
Is this based on the submit method?
| @@ -126,6 +127,147 @@ def push(image, phase, url, public, private): | |||
| max_docker_image_size = response.get("max_docker_image_size") | |||
|
|
|||
| docker_image_size = docker_image.__dict__.get("attrs").get("VirtualSize") | |||
| # Prompt for submission details | |||
|
|
||
| # After collecting submission_attribute_metadata | ||
| if submission_attribute_metadata: | ||
| submission_metadata["submission_meta_attributes"] = submission_attribute_metadata |
There was a problem hiding this comment.
Where is this submission metadata pushed to EvalAI?
There was a problem hiding this comment.
I see it on line 352. Nvm.
| @@ -442,7 +442,7 @@ def pretty_print_challenge_phase_data(phase): | |||
|
|
|||
| title = "{} {} {}".format(phase_title, challenge_id, phase_id) | |||
|
|
|||
| cleaned_desc = BeautifulSoup(phase["description"], "lxml").text | |||
| cleaned_desc = BeautifulSoup(phase["description"], "html.parser").text | |||
There was a problem hiding this comment.
Why are we making this change?
There was a problem hiding this comment.
When I tried to run CLI and fetch the challenge by id, it showed a parsing error, so I used this to fix it.
There was a problem hiding this comment.
Are you sure it doesn't break any of the old functionality?
There was a problem hiding this comment.
@gchhablani I think this lxml, html.parser is used to actually write fetched text in a cleaner way in terminal(CLI)
So I have tested this in my local environment by fetching challenge details etc
I don't see this breaking any functionality.
| @@ -135,7 +135,7 @@ def clean_data(data): | |||
| """ | |||
| Strip HTML and clean spaces | |||
| """ | |||
| data = BeautifulSoup(data, "lxml").text.strip() | |||
| data = BeautifulSoup(data, "html.parser").text.strip() | |||
There was a problem hiding this comment.
Same here, why this change?
There was a problem hiding this comment.
This Fix Parsing error on CLI
Harshit28j
force-pushed
the
add_docker_based_meta_submission
branch
from
d51eb04 to
a652d0f
Compare
Harshit28j
force-pushed
the
add_docker_based_meta_submission
branch
from
34a1480 to
7142815
Compare
tests/test_submissions.py
Outdated
| @@ -336,7 +335,6 @@ def test_make_submission_when_file_is_valid_with_metadata(self): | |||
| input="Y\nTest\nTest\nTest\nTest\nY\nTest\nA\nalpha\nTrue\n", | |||
| ) | |||
| assert result.exit_code == 0 | |||
| assert result.output.strip() == expected | |||
There was a problem hiding this comment.
Don't remove this line.
tests/test_submissions.py
Outdated
| @@ -293,7 +293,6 @@ def test_make_submission_when_file_is_valid_without_metadata(self): | |||
| input="N\nN", | |||
| ) | |||
| assert result.exit_code == 0 | |||
| assert result.output.strip() == expected | |||
There was a problem hiding this comment.
Don't remove this line.
No description provided.