-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added command to display contents of stdderr file #255
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add tests
@vkartik97 Alright |
I also made all the responses into variables so changing them won't be ann issue :) @vkartik97 @Ram81 @RishabhJain2018 |
@nsjcorps Still the code coverage is decreased. Can you resolve it? |
I mentioned the reason why the code coverage is down @pushkalkatara |
There is a part of the function that I can not test because it never gets called which I showed above. That would be the exception raised for the MissingSchema @pushkalkatara |
If the exception was raised in the request block of code it would be called. However, it is not raised there @pushkalkatara |
Should I put it there so you can see? |
evalai/utils/submissions.py
Outdated
except requests.exceptions.MissingSchema: | ||
echo( | ||
style( | ||
"\nThe Submission is yet to be evaluated.\n", | ||
bold=True, | ||
fg="yellow", | ||
) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why have you used requests.exceptions.MissingSchema
.
Going by docs,MissingSchema
is for The URL schema (e.g. http or https) is missing.
exception.
What should I use @vkartik97 ? I took it from the display submission result function. Kindly let me know your comments |
The Aim here is to find which condition is applicable for:
How about you check the status of submission data? How about |
Workin on It now @vkartik97 |
Done @pushkalkatara @vkartik97 |
Done!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
Thanks @vkartik97 |
I have added a command to display the contents of the stderr file
It is invoked by running
evalai submission SUBMISSION_ID stderr