Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logger examples in eval script #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gchhablani
Copy link
Contributor

This PR adds examples for logger in evaluation script and adds some suggestions in the README.

@@ -62,6 +62,22 @@ If you are looking for a simple challenge configuration that you can replicate t

11. To update the challenge on EvalAI, make changes in the repository and push on `challenge` branch and wait for the build to complete.

### Printing and Logging in Evaluation Script
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to Logging in Evaluation Script

Comment on lines +9 to +17
eval_script_logger = logging.getLogger(name='eval_script')
eval_script_logger.setLevel(logging.DEBUG)

handler = logging.StreamHandler(sys.stdout)
handler.setLevel(logging.DEBUG)
formatter = logging.Formatter('%(asctime)s - %(name)s - %(levelname)s - %(message)s')
handler.setFormatter(formatter)
eval_script_logger.addHandler(handler)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you create a new method called get_logger in this script and use that to get the logger here?

### Printing and Logging in Evaluation Script
`print` statements will show up on the console directly.
In order to get `logging` statements from the evaluation script, ensure that the logger has a `stdout` handler added. We redirect the output from `stdout` to the submission workers console.
An example logger can be created like so:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to Here's an example of setting up a logger:

eval_script_logger.addHandler(handler)
```

Then, we can use this logger anywhere in the script and the corresponding level logs will show up in the output.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chnage to Once set up, you can use the logger anywhere in the evaluation script to display logs on EvalAI manage tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants