Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows custom CAs #193

Closed
Clon1998 opened this issue Jul 1, 2023 · 2 comments
Closed

Allows custom CAs #193

Clon1998 opened this issue Jul 1, 2023 · 2 comments
Assignees

Comments

@Clon1998
Copy link
Owner

Clon1998 commented Jul 1, 2023

Rather than just enabling the handling of self-signed certificates by overwriting badCertification, it would be better to give users the option of uploading 1..n custom CAs to accommodate a wider range of scenarios. However, it is also important to retain the ability to overwrite badCertification for maximum flexibility. It is important to note that only one of these options should be enabled at a time.

This will require the usage of a SecurityContext when creating either an HTTP or WS client

@Clon1998 Clon1998 added this to the Simple/Advanced PrinterAdd milestone Jul 1, 2023
@Clon1998 Clon1998 self-assigned this Jul 1, 2023
@TheTipo01
Copy link
Contributor

Wouldn't a simple popup letting the user trust the certificate presented by the web server suffice? Obviously while showing all the cert info, including the fingerprint.

@Clon1998
Copy link
Owner Author

Clon1998 commented Jul 2, 2023

Wouldn't a simple popup letting the user trust the certificate presented by the web server suffice? Obviously while showing all the cert info, including the fingerprint.

I will see how I do it.
Probably I will offer both options to tue User. However, the percentage of users to whom these feature is useful is very low anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants