Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/2025 ndc tracker feedback v2 #1702

Merged
merged 10 commits into from
Oct 23, 2024
Merged

Conversation

SARodrigues
Copy link
Collaborator

@SARodrigues SARodrigues commented Oct 22, 2024

  • 1.0 - What happens if we have +8 submissions on a same day?
    Feedback asked, options suggested. We should still see it with design before implementation
    Will be addressed separately when we have a clear plan
  • 1.1 - Change main subtitle
  • 1.2 - Adjust hyperlinks
  • 1.3 - Adjust alignment of white boxes and their titles
  • 1.4 - Adjust area that is actionable in the toggle feature
    Addressed separately in 2015 NDC tracker feedback - Chart sorting switch to be clickable in a more user friendly way #1703
  • 1.5 - Copyedit
    This refers to the trailing space in the TrackerChartComponent's description
  • 1.5 - Copyedit
    This refers to the Abbr Replacements that are native to the platform
    • Page Title
    • Timeline Description

@SARodrigues SARodrigues self-assigned this Oct 22, 2024
@Bluesmile82
Copy link
Collaborator

For 1.0 we already have the scroll on the tooltips

@SARodrigues
Copy link
Collaborator Author

SARodrigues commented Oct 22, 2024

For 1.0 we already have the scroll on the tooltips

It's not the tooltips that appear when we hover over a day "circle". It's the list of countries displayed below said circle.
If we display enough countries they'll overflow the blue "intro" area and they'll be hidden.

As for scrolling I don't think it'll be the correct solution, because when duplicating entries for testing, if you have a Mac and depending on its default scrolling centers, it may happen that the user doesn't see a scrollbar at all indicating that there are more countries to be displayed, so perhaps adding the "..." would provide a visual indicator that the list is not complete; at least it looks like the easiest way to implement this without an overhaul.

The alternative would be to have the Intro component expand to support this, but I don't think this would be a quick solution due to the fact we'd have to tweak the component that displays Intros (which is heavily used across the platform) to expand vertically, as well as tweak the Timeline component to ensure the overflow would work. A simple indicator I feel would suffice here, as once the user hovers they'll have a tooltip with the full list of countries that would be scrollable.

@SARodrigues SARodrigues marked this pull request as ready for review October 23, 2024 11:14
@SARodrigues
Copy link
Collaborator Author

Merging existing changes to staging in order for them to be available for visual QA; will continue work on the toggle on a separate branch.

@SARodrigues SARodrigues merged commit fd53f55 into develop Oct 23, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants