Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change every mention of LUCF to LULUCF #1679

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

SARodrigues
Copy link
Collaborator

Overview

This PR changes every mention of "LUCF" to "LULUFC" throughout the app.

This is the FE counterpart to the changes already made in the data, which would cause certain parts/modules of the app to not function correctly, namely:

  • GHG Emissions module showing no data
  • Country specific donut and bar charts not showing
  • Agriculture module not displaying the donut chart
  • Data explorer showing no data

Note:
A few more sections may be still non-functional or defective, due to a separate INDC data bug.

Tracking

Basecamp

@SARodrigues SARodrigues self-assigned this Feb 1, 2024
@SARodrigues SARodrigues merged commit 48117c1 into develop Feb 1, 2024
2 of 3 checks passed
Copy link

what-the-diff bot commented Feb 1, 2024

PR Summary

  • Updates in Terminology

    • Various instances of the abbreviation 'LUCF' have been updated to 'LULUCF' across several files. This ensures consistency of terminology in the project.
  • Removal of Unnecessary Entries

    • The entries 'LULUCF' from the CONFLICTS object and 'LUCF' from the ABBREVIATIONS object, in the abbr-replace-data.js file, have been removed.
  • Data Adjustments

    • In the about-faq-data.js file, the 'LUCF' item was eradicated from the sectionsData array.

These changes seem to indicate an effort to streamline and harmonize the use of certain abbreviations and terms in the project. It should help reduce confusion and improve the readability and comprehensibility of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant