-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
render fix for tag color and write some unit tests #387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @dmlb ! See above for my feedback. I think end to end testing would be good for the project, but unit testing might be a bit overkill for the simplicity of the project. Let me know if you disagree though, curious to know what you think.
@dmlb I think this is ready to merge now? In terms of workflow for PRs, feel free to re-request reviews so that I know that you're done making changes (or ping me with "good to go" or something). I don't mind being pinged :) |
@VeckoTheGecko updated 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Describe your changes
Adding some unit tests to confirm the colour utilities and component for tag colour are doing what they're supposed to
Fixes #375
needed key on for loop!