Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CM-831 Personal values button only after quiz #228

Merged

Conversation

NickCallaghan
Copy link
Member

@NickCallaghan NickCallaghan commented Aug 20, 2021

The menu options for personal values and and retake the quiz should only show when the user has re-taken the quiz.

It was using session id instead of quiz id - oversight from a previous story.

Improved cypress tests to check for the correct menu options

Copy link
Member

@rodriguesk rodriguesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this so promptly!

@NickCallaghan NickCallaghan merged commit 97ee545 into develop Aug 23, 2021
@rodriguesk
Copy link
Member

rodriguesk commented Aug 29, 2021

@NickCallaghan This is merged into develop yet the bug is still happening from what I can tell on the test environment. Can you confirm this bug has been resolved?

@SabineU it still happens for me when I take the quiz, then just after finishing it I click retake quiz from the hamburger menu and then hit back on the browser then the personal values page is blank.

@NickCallaghan NickCallaghan deleted the CM-831_PV_Menu_option_should_only_show_after_quiz branch November 21, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants