Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feedback model added #481

Merged
merged 1 commit into from
Jan 9, 2023
Merged

feedback model added #481

merged 1 commit into from
Jan 9, 2023

Conversation

danmash
Copy link
Member

@danmash danmash commented Jan 9, 2023

Detailed information:

New Feedback model to handle users' feedback

Test plan (required)

  • The PR contains new PyTest unit/integration tests for any function or functional added.
  • The PR does not lead to degradation in unit test coverage.

@codecov-commenter
Copy link

Codecov Report

Base: 72.26% // Head: 72.75% // Increases project coverage by +0.48% 🎉

Coverage data is based on head (d4391ce) compared to base (f965826).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #481      +/-   ##
===========================================
+ Coverage    72.26%   72.75%   +0.48%     
===========================================
  Files           82       85       +3     
  Lines         2639     2679      +40     
  Branches       315      315              
===========================================
+ Hits          1907     1949      +42     
+ Misses         696      695       -1     
+ Partials        36       35       -1     
Impacted Files Coverage Δ
app/__init__.py 91.04% <100.00%> (+0.27%) ⬆️
app/feedback/__init__.py 100.00% <100.00%> (ø)
app/feedback/routes.py 100.00% <100.00%> (ø)
app/feedback/schemas.py 100.00% <100.00%> (ø)
app/models.py 100.00% <100.00%> (ø)
app/scoring/tests/data.py 100.00% <0.00%> (+6.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@danmash danmash merged commit bc25382 into develop Jan 9, 2023
@delete-merged-branch delete-merged-branch bot deleted the feedback branch January 9, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants