Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace session cypress test with equivalent pytest #473

Merged
merged 2 commits into from
Dec 10, 2022

Conversation

brianpeiris
Copy link
Member

Detailed information:

  • Deleted session.cy.js and replaced it with an equivalent pytest in app/session/tests/test_session_routes.py

Closing issues:

List all issues the pull request solve:

Test plan (required)

  • The PR contains new PyTest unit/integration tests for any function or functional added.
  • The PR changes existing PyTest unit/integration tests to keep all tests up to date.
  • The PR does not lead to degradation in unit test coverage.
  • Project parts affected by changes in this PR was tested manually on your local (using Postman or in any other way). List everything you've tested below:
    • Ran all pytests
    • Ran all cypress tests

@codecov-commenter
Copy link

Codecov Report

Base: 68.11% // Head: 68.19% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (4c505f2) compared to base (bddfc4d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #473      +/-   ##
===========================================
+ Coverage    68.11%   68.19%   +0.07%     
===========================================
  Files           81       81              
  Lines         2569     2569              
  Branches       313      313              
===========================================
+ Hits          1750     1752       +2     
  Misses         788      788              
+ Partials        31       29       -2     
Impacted Files Coverage Δ
app/scoring/tests/data.py 100.00% <0.00%> (+3.33%) ⬆️
app/session/routes.py 100.00% <0.00%> (+4.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

app/session/tests/test_session_routes.py Outdated Show resolved Hide resolved
Copy link
Member

@danmash danmash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adjustment

@danmash danmash merged commit 7a92809 into ClimateMind:develop Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace cypress session.cy.js with PyTest integration tests.
4 participants