Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CM-1120 Include descriptionShared #411

Merged
merged 1 commit into from
Oct 15, 2022

Conversation

rodriguesk
Copy link
Member

Detailed information:

Explain the details of making this change.
Please provide enough information so that others can review your pull request

Closing issues:

List all issues the pull request solve:

  • #XX1
  • #XX2

Test plan (required)

  • The PR contains new PyTest unit/integration tests for any function or functional added.
  • The PR changes existing PyTest unit/integration tests to keep all tests up to date.
  • The PR does not lead to degradation in unit test coverage.
  • Project parts affected by changes in this PR was tested manually on your local (using Postman or in any other way). List everything you've tested below:
    • Part 1
    • Part 2

@rodriguesk rodriguesk requested a review from danmash October 14, 2022 18:36
@rodriguesk rodriguesk changed the title Include descriptionShared CM-1120 Include descriptionShared Oct 14, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 61.88% // Head: 61.80% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (e4bf334) compared to base (c698b82).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #411      +/-   ##
===========================================
- Coverage    61.88%   61.80%   -0.08%     
===========================================
  Files           79       79              
  Lines         2545     2545              
  Branches       318      318              
===========================================
- Hits          1575     1573       -2     
- Misses         956      957       +1     
- Partials        14       15       +1     
Impacted Files Coverage Δ
app/alignment/utils.py 35.33% <ø> (ø)
app/scoring/tests/data.py 93.33% <0.00%> (-6.67%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@danmash danmash merged commit 42ecbab into develop Oct 15, 2022
@delete-merged-branch delete-merged-branch bot deleted the CM-1120-update-shared-description branch October 15, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants